fix: [https://nvbugspro.nvidia.com/bug/5243482] If FlashMLA is used, the existence of FMHA based MLA kernels should not be checked. #3862
Conversation
For Generation MLA, if FlashMLA is used, do not check the existence of FMHA based MLA kernel. Signed-off-by: Bo Li <[email protected]>
|
@bobboli does this fix affect Blackwell and Hopper? And does 0.19 has the issue? if so, pls also help fix it in the release/0.19. Thx |
juney-nvidia
changed the title
|
/bot run |
|
PR_Github #3570 [ run ] triggered by Bot |
Hi @litaotju , this bug only affects Hopper since Blackwell goes trtllm-gen codepath rather than fmha_v2. The bug is introduced to main after the PR to update sm120 cubins, which also deleted the (unused) sm90 FP8 MLA kernel. I verified release/0.19 is okay since the PR is not merged into release. |
|
PR_Github #3570 [ run ] completed with state |
Signed-off-by: Bo Li <[email protected]>
Signed-off-by: Bo Li <[email protected]>
|
/bot run |
|
PR_Github #3750 [ run ] triggered by Bot |
|
PR_Github #3750 [ run ] completed with state |
Signed-off-by: Bo Li <[email protected]>
|
/bot run |
|
PR_Github #3787 [ run ] triggered by Bot |
|
PR_Github #3787 [ run ] completed with state |
Description
Add mIsGenerationMLA to differentiate ctx and gen MLA in AttentionOp.
For Generation MLA, if FlashMLA is used, do not check the existence of FMHA based MLA kernel.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.